Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patient List: Condition colour code not appearing #352

Open
saratheneale opened this issue Jun 26, 2019 · 9 comments
Open

Patient List: Condition colour code not appearing #352

saratheneale opened this issue Jun 26, 2019 · 9 comments
Labels
bug A defect in design or behaviour needs-replication Need reliable instructions for replicating this issue P1 Broken core functionality / Required feature

Comments

@saratheneale
Copy link

saratheneale commented Jun 26, 2019

Happening on version 62867f7

This is both a bug AND a crash! Check it out

Steps to Reproduce:

  1. Add New Patient -
  2. Add Observation with Condition 3, Temp 36, Pulse 55, Blood Pressure systolic 12050
  3. save.
  4. Go back to Triage

Result: Patient is white. (Has not been 1 minute since server synced).
Expected: Patient color code should be Red to correspond with Critical.
Note: I waited 2 minutes for any sync to happen and redid the search.

  1. Close app
  2. Reopen
  3. Search for patient
  4. Result: Color is still white.
  5. Click patient Crash maybe?
  6. if not, Click Back. THEN CRASH!

Result: Crash. Log coming.

@saratheneale saratheneale added bug A defect in design or behaviour P0 Crash or data loss labels Jun 26, 2019
@saratheneale
Copy link
Author

Here is the crash after Clicking patient and then clicking the back button. See Fatal Exception at 06-27 00:41:41.783 UTC IRL

352.txt

@saratheneale
Copy link
Author

saratheneale commented Jun 27, 2019

Here's a screenshot and a long log. Reconfirmed on version 0.11.1+57

This bug was mostly consistent, but one time it worked as expected. The rest of the patients here are in condition Critical or Unwell.

Screenshot_20190626-191339_Buendia

See Fatal Exception at 07:13 pm PST (Right before 07:14)

352a.txt

@mjanes mjanes self-assigned this Jun 27, 2019
@zestyping
Copy link
Contributor

I can't seem to replicate this on my tablet. I've tried the exact steps given, a few times, and each time (a) the patient immediately shows up with a red chip in the patient list as expected and (b) I can navigate around and there's no crash.

@saratheneale
Copy link
Author

saratheneale commented Jun 27, 2019

Steps to Repro

  1. Open Buendia. Log in as User
  2. You are in the Locations Screen. Add a New Patient
  • Confirm you are in the Patient Chart / Record
  1. Add an observation with values above. Definitely change the condition
  2. Save
  3. Click Back button in app
  4. Filter patients by name. Type in the name you just added
  5. Click the new patient you just added.
  • Note sometimes the color code updates in this view. Sometimes it doesn't.
  1. Click Back button in app again.
    Result: Crash!

OUTDATED
352b.txt
352c.txt

@mjanes
Copy link
Contributor

mjanes commented Jun 27, 2019

I also cannot reproduce. Patient shows up with red chip, and I can navigate and not see a crash.

@mjanes
Copy link
Contributor

mjanes commented Jun 27, 2019

Cannot replicate the color chip not appearing. Looking at the logs, the bandaid fix for #298 may have resolved the crash.

@saratheneale
Copy link
Author

saratheneale commented Jun 27, 2019

This log uses adb logcat | egrep 'Android|buendia/ from adding patient thru the would have crashed "Please report"
352June27a.txt

@zestyping
Copy link
Contributor

@saratheneale Sorry I didn't catch this right away—do you recall (or can you find) the name or ID of the newly created patient that failed to show the correct chip colour (in the test that generated 352June27a.txt)?

@mjanes mjanes removed their assignment Jun 27, 2019
@zestyping
Copy link
Contributor

The fix in #350 seems to avoid the crash — as far as I know, we haven't seen an actual crash since the testing party (just the warning that we pop up indicating that a crash would have occurred). So, I'm demoting this from a crash bug to a display bug (the condition colour code not showing up).

@zestyping zestyping changed the title Crash: Add new Patient and Observation doesn't add color code and crashes the app. Patient List: Condition colour code not appearing Jul 1, 2019
@zestyping zestyping added P1 Broken core functionality / Required feature and removed P0 Crash or data loss labels Jul 1, 2019
@zestyping zestyping added the needs-replication Need reliable instructions for replicating this issue label Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in design or behaviour needs-replication Need reliable instructions for replicating this issue P1 Broken core functionality / Required feature
Projects
None yet
Development

No branches or pull requests

3 participants