-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors with IE10 and Babel 6 #137
Comments
A bit more investigation has shown the problem to be caused by uninheritable static properties on IE10 and below with Babel which can be fixed by adding the transform-proto-to-assign babel plugin when building react-forms. I tested it on the examples included with react-forms and it works. |
This is also an issue with react-stylesheet. For the moment I am including my own pre-built modules for react-stylesheet and react-forms in my project, so it's no longer affecting me, however it might be beneficial to apply this fix in your build files. |
@ifunk can you provide some details about that pre-built you're mentioning on your last comment. Trying to figure out how to rebuild |
@elmorenocivitas The repo has changed since I built mine, but if you clone react-forms repo then install and add the mentioned babel plugin to the "babel" config in package.json, then run In my project I set up an alias in webpack so I could still use
|
Thanks for the answer @ifunk. Our build |
@leomoreno Same as us, which is why I build it manually and then copy the files into our project. |
No room for manual builds here. I need a different approach I guess. The whole dependency install and bundling process needs to be automated. |
Trying to get react-forms working with IE10, but am getting the following error:
So I added the following before using Fieldset:
And the above error went away, but I got a new one:
I tried a few other things without success, so I am wondering if you've experienced this issue before and know of a solution. The original code works as expected in IE11 (and all other browsers I've tested).
I'm guessing it's probably a Babel 6 bug or known incompatibility. I've tried a few different options with Babel transforms, but nothing solved the problem.
Any ideas?
The text was updated successfully, but these errors were encountered: