From 9f8a067032bdc010d71956587b58258feb00d341 Mon Sep 17 00:00:00 2001 From: Damien Goutte-Gattat Date: Fri, 17 May 2024 13:34:31 +0100 Subject: [PATCH 1/2] Test all profiles in CI. When running the test suite on GitHub, make sure all profiles are tested, to catch any breakage of a profile-specific configuration. When testing the "release" profile, signing of the packages is explicitly disabled to avoid needless access to the release signing key. --- .github/workflows/ci.yml | 7 +++++-- pom.xml | 3 +++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5b5242601..b179fa6f4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -8,7 +8,10 @@ on: workflow_dispatch: jobs: - publish: + test: + strategy: + matrix: + profile: [ default, ide, release ] runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 @@ -18,4 +21,4 @@ jobs: java-version: '11' distribution: 'adopt' - name: Run test suite - run: mvn --batch-mode test + run: mvn --batch-mode verify --activate-profiles ${{ matrix.profile }} --define release.signing.disabled=true clean verify diff --git a/pom.xml b/pom.xml index 246145bcb..6f0ac9108 100644 --- a/pom.xml +++ b/pom.xml @@ -526,6 +526,9 @@ org.apache.maven.plugins maven-gpg-plugin + + ${release.signing.disabled} + sign-artifacts From 2d8d83f41448df462035a81d2ba05e883736e1ea Mon Sep 17 00:00:00 2001 From: Damien Goutte-Gattat Date: Fri, 17 May 2024 13:45:35 +0100 Subject: [PATCH 2/2] Don't invoke phases twice. --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b179fa6f4..2a0bf267a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,4 +21,4 @@ jobs: java-version: '11' distribution: 'adopt' - name: Run test suite - run: mvn --batch-mode verify --activate-profiles ${{ matrix.profile }} --define release.signing.disabled=true clean verify + run: mvn --batch-mode --activate-profiles ${{ matrix.profile }} --define release.signing.disabled=true clean verify