Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deposit when buying with fiat #139

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add deposit when buying with fiat #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/book.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,18 @@ def _read_coinbase(self, file_path: Path) -> None:
# If it's a buy, add the corresponding sell to complement
# the trading pair.
elif operation == "Buy":
# If coins were bought with fiat, first add a corresponding deposit
if misc.is_fiat(_currency_spot):
eur_total = misc.force_decimal(_eur_total)
self.append_operation(
"Deposit",
utc_time,
platform,
eur_total,
_currency_spot,
row,
file_path,
)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it's also possible to deposit fiat first and buy later on, we have to check against that and can not merely add a deposit action.

It might be ok to disable tracking of deposit and withdrawals with home fiat which might solve most of the problem.
We can add a config variable for that. and should raise a warning when we adjust the config variable while evaluating the coinbase account statement, which as a buy with fiat.

If it is still bothering we should add a file in parallel which lists all buys to coinbase and initialize there value as 0 (do not add deposit on default). The user can adjust the file so that deposits will be added on the second run.

The format of the could be ini (csv might be a good "normal" format, but editing csv with Excel fucks up the format most of the time which might create a headache for most of the users) and should be saved in the account statements folder.

assert isinstance(eur_subtotal, decimal.Decimal)
self.append_operation(
"Sell",
Expand All @@ -435,7 +447,7 @@ def _read_coinbase_v2(self, file_path: Path) -> None:
self._read_coinbase(file_path=file_path)

def _read_coinbase_pro(self, file_path: Path) -> None:
platform = "coinbase_pro"
platform = "coinbase"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in #138, instead of making them the same, we should consider the deposits/withdrawals between them.

operation_mapping = {
"BUY": "Buy",
"SELL": "Sell",
Expand Down