Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detailed export #98
Detailed export #98
Changes from 8 commits
cb83e91
f1d68ce
8aad810
6d83bb6
d2f51f9
82d2705
d8bfeca
ec6b8ef
4912360
f7adc22
821122f
7b6beb2
55ef433
6415130
0bef72a
cb0f5c6
5f5a276
9511d16
8bb18ed
96b4c07
d347127
c383bdc
9d19ecb
90f2179
189367e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
evaluate_sell
shouldn't return None if we want to export all events.evaluate_sell
should calculate thereal_gain
, which currently missing.