-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Bring back support for long file names and timestamps in M20 L T g-code command #3054
Comments
Thanks for reporting. Our developers will look into this. Michele Moramarco |
I just wrote a PR #3765 for this issue. |
This issue has been flagged as stale because it has been open for 60 days with no activity. The issue will be closed in 7 days unless someone removes the "stale" label or adds a comment. |
This issue has been closed due to lack of recent activity. Please consider opening a new one if needed. |
This shouldn't have been closed since there are several PRs basically solving it. |
This is yet another feature that is missing in the MK4 firmware that was present in MK3. |
It's been almost a year and a half. Maybe they should look harder? |
Please, before you create a new bug report, please make sure you searched in open and closed issues and couldn't find anything that matches.
Printer type - MK4, MK3.5
Printer firmware version - 4.5.4, 5.2.0
Original or Custom firmware - Original
Describe the bug
M20 command issued over serial doesn't list long file names and doesn't list timestamps.
This feature existed for many years in MK3 firmware but is missing from MK4 firmware.
How to reproduce
Issue
over serial.
Expected behavior
Long file names and timestamps (in form of hex numbers) are shown.
More info
Code for that exists in MK3 firmware and also Marlin 2.1.2+ (
guarded by LONG_FILENAME_HOST_SUPPORT
https://github.com/MarlinFirmware/Marlin/blob/2.1.2.2/Marlin/src/sd/cardreader.cpp#L304-L314
https://github.com/MarlinFirmware/Marlin/blob/2.1.2.2/Marlin/src/gcode/sd/M20.cpp#L46
and M20_TIMESTAMP_SUPPORT defs,
https://github.com/MarlinFirmware/Marlin/blob/2.1.2.2/Marlin/src/sd/cardreader.cpp#L327C3-L336C8
https://github.com/MarlinFirmware/Marlin/blob/2.1.2.2/Marlin/src/gcode/sd/M20.cpp#L47
so will be easier to see what's needed for backporting).
The text was updated successfully, but these errors were encountered: