Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Bring back support for long file names and timestamps in M20 L T g-code command #3054

Open
arekm opened this issue Apr 19, 2023 · 7 comments
Assignees
Labels
bug Something isn't working. enhancement Improvement proposal based on existing features. feature request A request for adding a specific feature of change of behaviour.

Comments

@arekm
Copy link

arekm commented Apr 19, 2023

Please, before you create a new bug report, please make sure you searched in open and closed issues and couldn't find anything that matches.

Printer type - MK4, MK3.5

Printer firmware version - 4.5.4, 5.2.0

Original or Custom firmware - Original

Describe the bug

M20 command issued over serial doesn't list long file names and doesn't list timestamps.
This feature existed for many years in MK3 firmware but is missing from MK4 firmware.

How to reproduce

Issue

M20 L T

over serial.

Send: M20 L T
Recv: Begin file list
Recv: T-NUT_~1.GCO
Recv: End file list

Expected behavior

Long file names and timestamps (in form of hex numbers) are shown.

Send: M20 L T
Recv: Begin file list
Recv: T-NUT_~1.GCO 1061513 0x5690a164 "T-nut_M3_x12_20m.gcode"
Recv: End file list

More info
Code for that exists in MK3 firmware and also Marlin 2.1.2+ (
guarded by LONG_FILENAME_HOST_SUPPORT
https://github.com/MarlinFirmware/Marlin/blob/2.1.2.2/Marlin/src/sd/cardreader.cpp#L304-L314
https://github.com/MarlinFirmware/Marlin/blob/2.1.2.2/Marlin/src/gcode/sd/M20.cpp#L46

and M20_TIMESTAMP_SUPPORT defs,
https://github.com/MarlinFirmware/Marlin/blob/2.1.2.2/Marlin/src/sd/cardreader.cpp#L327C3-L336C8
https://github.com/MarlinFirmware/Marlin/blob/2.1.2.2/Marlin/src/gcode/sd/M20.cpp#L47

so will be easier to see what's needed for backporting).

@arekm arekm added the bug Something isn't working. label Apr 19, 2023
@Prusa-Support Prusa-Support added enhancement Improvement proposal based on existing features. feature request A request for adding a specific feature of change of behaviour. labels Jun 6, 2023
@Prusa-Support
Copy link
Collaborator

Thanks for reporting.

Our developers will look into this.

Michele Moramarco
Prusa Research

@bkerler
Copy link
Contributor

bkerler commented Feb 18, 2024

I just wrote a PR #3765 for this issue.

Copy link

This issue has been flagged as stale because it has been open for 60 days with no activity. The issue will be closed in 7 days unless someone removes the "stale" label or adds a comment.

Copy link

This issue has been closed due to lack of recent activity. Please consider opening a new one if needed.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 20, 2024
@danopernis danopernis self-assigned this Aug 19, 2024
@danopernis
Copy link
Member

This shouldn't have been closed since there are several PRs basically solving it.

@danopernis danopernis reopened this Aug 19, 2024
@timur-tabi
Copy link

timur-tabi commented Oct 30, 2024

This is yet another feature that is missing in the MK4 firmware that was present in MK3.

@timur-tabi
Copy link

Thanks for reporting.

Our developers will look into this.

It's been almost a year and a half. Maybe they should look harder?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. enhancement Improvement proposal based on existing features. feature request A request for adding a specific feature of change of behaviour.
Projects
None yet
Development

No branches or pull requests

5 participants