[BFW-6788] [BUG] Core One has no CHAMBER_TEMPERATURE capability and does not report C temperature

[ulab]

Printer model

Core One

Firmware version

6.3.0+10073

Upgrades and modifications

None

Printing from...

does not apply

Describe the bug

The Core One reports it has no CHAMBER_TEMPERATURE capability on M115:

Send: M115
FIRMWARE_NAME:Prusa-Firmware-Buddy 6.3.0+10073 (Github) SOURCE_CODE_URL:https://github.com/prusa3d/Prusa-Firmware-Buddy PROTOCOL_VERSION:1.0 MACHINE_TYPE:Prusa-COREONE EXTRUDER_COUNT:1 UUID:cede2a2f-41a2-4748-9b12-c55c62f367ff
                                                                                                                                                                                                                                  Cap:SERIAL_XON_XOFF:0
[...]
Cap:CHAMBER_TEMPERATURE:0
ok

It also does not report the chamber temperature (C) on M105 or M155?

T:26.50/0.00 B:59.83/90.00 X:26.98/36.00 A:40.91/0.00 @:0 B@:255 HBR@:0

How to reproduce

Send the above GCodes M115, M105 and M155 ... over the serial interface.

Expected behavior

CHAMBER_TEMPERATURE should show 1 and the temperature reports should have a C with the chamber temperatures.

Files

No response

[ulab]

I am guessing the cause for this is that Marlin expects active heating for the chamber?

HAS_TEMP_CHAMBER instead of HAS_HEATED_CHAMBER might be enough, but I am not sure if changing the capabilities this way will mess with something else.

But then I am not sure why it doesn't print C on M105 or M155. The code looks like it should.

[CZDanol]

Oh I was wondering when someone would come up with this :)

Yes, we didn't implement the chamber temperature through the standard Marlin structures, because Marlin code is hell, plus it only considers heated enclosures, and the API overall was not powerful enough for our needs.

This resulted in our chamber code to be actually sane, but we are left with having to hack back some of the OG Marlin support for the Octo guys.

[ulab]

I was mostly trying to get a log of the chamber temperature over time depending on different bed temps and to see how well the cooling works. :)

But I guess the Octo guys might want these too, yes.

[CZDanol]

Created internal ticket BFW-6788

[bkerler]

I just pushed a PR to make C1 great again :)

[bkerler]

The PR has been modified and doesn't compile as of now, but that is intended as is. Reason is: The chamber api will be separated and then the PR will be updated and included.

[CZDanol]

We will try to finish it up internally