-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Too much MK3S<->MMU2 communication logging on serial port #4414
Comments
I agree with this. It would be nice to hide the Query (Q0) if nothing has changed since the last Q0. Q0 triggers every 1 second |
@thess Nice to see you back on this repo. We have been discussing this few times and we gonna keep it for the moment. Here my OctoPrint Filter for the Terminal output: Some parts of my
Changed BTW: PrusLink/PrusaConnect and OctoPrint Plugins may/could use this serial logging to check the state/operations of the MMU3 😉 |
@thess I have a working pull request which shrinks the logging activity quite a bit. My proposal is to allow the full logging activity while the MMU is running a toolchange or any other command. But while it's sitting idle (e.g. after the toolchange is done) none of the "spammy" messages will get logged. Would this be an acceptable solution in your opinion? My proposal only costs around ~40 bytes of flash memory. |
I'll give your PR a try next week and see how it goes. I am using the Octoprint MMU2 plugin now in conjunction with serial filters. You proposal looks like the best compromise (so far). I also did a version of the firmware for my own use with the MMU serial logging disabled but then the Octoprint plugin is not usable. |
Sorry for the late response -- Suppressing logging when idle is an acceptable solution. The Octoprint plugin is definitely usable. There may be some status info missed by the plugin at startup but I haven't done enough checking. OK to close this if #4455 is merged. |
Printer type - MK3S
Printer firmware version - 3.13.1+
MMU upgrade - MMU2S
MMU upgrade firmware version - 3.0.0, 3.0.1
SD card or USB/Octoprint
Mainly USB/Octoprint
Describe the bug
Serial communications between the printer and MMU are continually output on the USB port.
To Reproduce
Connect to USB serial and notice continual chatter.
Expected behavior
We need a way to suppress these messages from log output either by:
I suppose one could write an Octoprint serial filter to remove the transactions from the console but I would prefer not to have the excess data always clogging the serial communications path.
The text was updated successfully, but these errors were encountered: