Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badly formatted trustedApps setting in API server causes 500 error on login and others #421

Open
sgoumaz opened this issue Apr 11, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@sgoumaz
Copy link
Member

sgoumaz commented Apr 11, 2022

We don't validate the setting when loading the config or when using it (L61 is where it crashes), so that if trustedApps includes stuff such as *https://127.0.0.1*,*http://api.czene.co.uk:3000/* (i.e. missing the @) the caller gets a 500 error on login and other methods involving auth.

TBD: should we raise the error on server startup in the config validation (linked above) or elsewhere?


As signalled in customer tickets: Magnes (again here), probably also Accord/Swordfish

@sgoumaz sgoumaz added the bug Something isn't working label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Ready
Development

No branches or pull requests

1 participant