From a9d0e45dd7e8b61eb9ad2c635de5f2c7bc85ddfc Mon Sep 17 00:00:00 2001 From: przemek83 <4788832+przemek83@users.noreply.github.com> Date: Sat, 4 Jan 2025 09:43:34 +0100 Subject: [PATCH] Refactor getDefaultVariantForFormat function to simplify control flow and ensure format validation. --- src/Utilities.cpp | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/src/Utilities.cpp b/src/Utilities.cpp index ede2283..8994aab 100644 --- a/src/Utilities.cpp +++ b/src/Utilities.cpp @@ -53,20 +53,14 @@ QString getXlsxTemplateName() QVariant getDefaultVariantForFormat(ColumnType format) { - switch (format) - { - case ColumnType::STRING: - return QVariant(QMetaType(QMetaType::QString)); + Q_ASSERT(format != ColumnType::UNKNOWN); - case ColumnType::NUMBER: - return QVariant(QMetaType(QMetaType::Double)); + if (format == ColumnType::NUMBER) + return QVariant(QMetaType(QMetaType::Double)); - case ColumnType::DATE: - return QVariant(QMetaType(QMetaType::QDate)); + if (format == ColumnType::DATE) + return QVariant(QMetaType(QMetaType::QDate)); - default: - Q_ASSERT(false); - } return QVariant(QMetaType(QMetaType::QString)); }