From c3577f410d6b0fd73ec2950b11ec41dfb1a1481b Mon Sep 17 00:00:00 2001 From: przemek83 <4788832+przemek83@users.noreply.github.com> Date: Sat, 4 Jan 2025 08:30:29 +0100 Subject: [PATCH] Refactor header content generation to use a static regular expression for improved performance and readability. --- src/ExportXlsx.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/ExportXlsx.cpp b/src/ExportXlsx.cpp index d80758e..b408a1c 100644 --- a/src/ExportXlsx.cpp +++ b/src/ExportXlsx.cpp @@ -77,10 +77,9 @@ QByteArray ExportXlsx::generateHeaderContent(const QAbstractItemModel& model) for (int j{0}; j < columnCount; ++j) { QString header{model.headerData(j, Qt::Horizontal).toString()}; + static const QRegularExpression regExp{QStringLiteral("[<>&\"']")}; const QString clearedHeader( - header - .replace(QRegularExpression(QStringLiteral("[<>&\"']")), - QStringLiteral(" ")) + header.replace(regExp, QStringLiteral(" ")) .replace(QStringLiteral("\r\n"), QStringLiteral(" "))); headersContent.append(")" +