Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProcessMessages() #13

Open
austinjoseph opened this issue Dec 8, 2020 · 0 comments
Open

ProcessMessages() #13

austinjoseph opened this issue Dec 8, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@austinjoseph
Copy link
Member

This method barely works. There is very little hardening against false messages and the message buffer is handled very poorly.

  • It must have all of it's methods broken into smaller methods that are called for readability.
  • It must have a more robust way of verifying messages and discarding bad messages.
  • It must be able to read around the ring (currently if a message is recieved near the end of the buffer it would just be cut off
    the message procesesor should know that and reset the pointer to the beginning of the buffer to finish validating).
  • It must have a checksum implemented
  • It should liklely have a type indicator in addition to the size indicator it has now
  • It should likely be encoded in HEX string commands instead of ASCII
@austinjoseph austinjoseph added the bug Something isn't working label Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant