Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout der Samples mit nur einer Spalte #7266

Closed
laske185 opened this issue Jan 22, 2025 · 0 comments · Fixed by #7369
Closed

Layout der Samples mit nur einer Spalte #7266

laske185 opened this issue Jan 22, 2025 · 0 comments · Fixed by #7369
Assignees
@sdvg
Labels
sample Relates to a sample in the sample-react project.

Comments

@laske185
Copy link
Contributor

laske185 commented Jan 22, 2025 •
edited
Loading

Damit der Vergleich bei Änderungen an einem Screenshot leichter fällt, darf das Layout nicht mehrspaltig sein, damit Alt und Neu direkt nebeneinander angezeigt werden.

Nur im Snapshot-Modus soll die Grid entfernt werden, damit die Komponenten alle untereinander dargestellt werden.

Image

Außerdem sind die 400 % Screenshots nicht realisitsch, da in einer App kein Zweispalten-Layout benutzt werden sollte, wenn der Bildschirm so schmal ist:

Image
@laske185 laske185 added maintenance Routine codebase upkeep and management tasks. sample Relates to a sample in the sample-react project. labels Jan 22, 2025
@laske185 laske185 moved this to 🗂️ Backlog in KoliBri Board Jan 22, 2025
@laske185 laske185 removed the maintenance Routine codebase upkeep and management tasks. label Jan 22, 2025
@sdvg sdvg mentioned this issue Jan 23, 2025
Merged
5 tasks
@laske185 laske185 mentioned this issue Jan 24, 2025
Open
@laske185 laske185 moved this from 🗂️ Backlog to 📄 Ready in KoliBri Board Feb 3, 2025
@sdvg sdvg self-assigned this Feb 6, 2025
@sdvg sdvg moved this from 📄 Ready to 🏗 In progress in KoliBri Board Feb 6, 2025
sdvg added a commit that referenced this issue Feb 7, 2025
@sdvg
Implement SampleColumns for conditional grid
e7f370a 
Refs: #7266
sdvg added a commit that referenced this issue Feb 7, 2025
@sdvg
Update sample app routes
ef9c823 
Refs: #7266
@sdvg sdvg linked a pull request Feb 7, 2025 that will close this issue
Sample App: Implement SampleColumns for conditional grid #7369
Merged
5 tasks
@sdvg sdvg mentioned this issue Feb 7, 2025
Merged
5 tasks
publicuibot bot pushed a commit that referenced this issue Feb 7, 2025
@sdvg @publicuibot
Update all snapshots$
a0a9fac 
$
Refs: #7266
sdvg added a commit that referenced this issue Feb 7, 2025
@sdvg
Remove non-existing snapshot page
714c7fe 
Refs: #7266
publicuibot bot pushed a commit that referenced this issue Feb 7, 2025
@sdvg @publicuibot
Update all snapshots$
a5971a2 
$
Refs: #7266
@sdvg sdvg moved this from 🏗 In progress to 🔍 Review in KoliBri Board Feb 7, 2025
@github-project-automation github-project-automation bot moved this from 🔍 Review to ✅ Done in KoliBri Board Feb 10, 2025
sdvg added a commit that referenced this issue Feb 11, 2025
@sdvg
Merge branch 'develop' of github.com:public-ui/kolibri into 6917-comb…
4bcaa1a 
…obox-fc

* 'develop' of github.com:public-ui/kolibri:
  Update all snapshots$ $ Refs: #7266
  Remove non-existing snapshot page
  Update all snapshots$ $ Refs: #7266
  Update sample app routes
  Implement SampleColumns for conditional grid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdvg sdvg

Labels
sample Relates to a sample in the sample-react project.
Projects
KoliBri Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sample App: Implement SampleColumns for conditional grid public-ui/kolibri
2 participants
@sdvg @laske185