Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types/pubnub for 5.x #263

Open
k-funk opened this issue Mar 18, 2022 · 2 comments
Open

@types/pubnub for 5.x #263

k-funk opened this issue Mar 18, 2022 · 2 comments

Comments

@k-funk
Copy link

k-funk commented Mar 18, 2022

Is it correct to assume that pubnub maintains typings in the DefinitelyTyped repo?
If so, it would be great to have the version numbers match up.

Reference:
@mohitpubnub
https://github.com/DefinitelyTyped/DefinitelyTyped/commits/master/types/pubnub/index.d.ts


Perhaps related, or perhaps it's intentionally left out:
interface StatusEvent { is missing the statusCode prop. I was expecting to see it there, to at least log 403s that come through.

@lauralouiset
Copy link

I've also found some inconsistencies with typing... specifically in version 7.2.0, fetchMessages returns a FetchMessagesResponse, though if you set includeMessageActions to true you get a 'more' property which is not mentioned in the FetchMessagesResponse type.

@mohitpubnub
Copy link
Contributor

To address said issues, PR is created at DefinitelyTyped.
This issue will be closed once the updated types will be published.

Thank You @k-funk and @lauralouiset for bringing the attention.
Sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants