Can not use declaritive import without esModuleInterop #410
Assignees
Labels
priority: medium
This PR should be reviewed after all high priority PRs.
status: in progress
This issue is being worked on.
type: chore
This PR contains changes that are not covered by other types (stylistic, dependency updates, etc).
Comments
parfeon
added
status: in progress
parfeon
added a commit
that referenced
this issue
Oct 30, 2024
Fix definition of type which represent message actions received from history and list of users which added action of specific type and value to the message. Closes #407 refactor(types): remove indexed signature for publish Remove redundant indexed signature from publish message parameters type definition. Closes #413 refactor(types): add serializable objects to `Payload` type Extend `Payload` type definition with objects which can be serialized by `JSON.stringify` using `toJSON()` methods. Closes #412 refactor(types): aggregate generated types definitions Aggregate multiple types definitions into single type definition type with proper type names and namespaces. Closes #405 #409 #410 refactor(types): add missing Subscribe Event Engine types Add Subscribe Event Engine and Event Listener types to the bundled types definition file. Closes #377
parfeon
added a commit
that referenced
this issue
Oct 31, 2024
fix(types): fix `Actions` type definition Fix definition of type which represent message actions received from history and list of users which added action of specific type and value to the message. Closes #407 refactor(types): remove indexed signature for publish Remove redundant indexed signature from publish message parameters type definition. Closes #413 refactor(types): add serializable objects to `Payload` type Extend `Payload` type definition with objects which can be serialized by `JSON.stringify` using `toJSON()` methods. Closes #412 refactor(types): aggregate generated types definitions Aggregate multiple types definitions into single type definition type with proper type names and namespaces. Closes #405 #409 #410 refactor(types): add missing Subscribe Event Engine types Add Subscribe Event Engine and Event Listener types to the bundled types definition file. Closes #377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the project-wide
esModuleInteropflag must be enabled in order to import thepubnubmodule using declarative syntax (import * as PubNub from 'pubnub'). Alternatively, dynamic import syntax may be used (import PubNub = require('pubnub')), but that carries its own list of disadvantages.This is fixed by simply declaring a
PubNubnamespace alongside the exported class like so:This matches the DefinitelyTyped package: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/pubnub/index.d.ts#L330
The text was updated successfully, but these errors were encountered: