"previous" and "next" navigation buttons do not remain when looking through catalog records from a list of results

[caroldh]

Expected behavior

I would expect that navigation buttons remain as an option, so that I can continue to view next (or previous) records in my list of results.

Actual behavior

I have a list of search results, and when I click into the 1st record, I can see the "previous" and "next" available for me to navigate through the list. But if I click "next" to view the next record in the list, I no longer see the "previous" and "next" buttons.
1st record, where navigation is possible:

After clicking "next" to see next record, buttons are no longer available:

Steps to replicate

Execute a search in catalog and get a list of results. Click on one of the records, and use "previous" or "next" to move in the list of results. On next record, you will no longer see options for "previous" or "next"

Impact of this bug

Cannot easily move through a list of search results.

Related Slack thread

[christinach]

Findings

Render ServerItemPaginationComponent

• The render of the 'SearchContext::ServerItemPaginationComponent' that includes the Previous and Next links does not happen because one of the conditions (@search_session['document_id'] == @current_document_id) in the def render method returns false.

• search context is always present.

<% if @search_context %>
      blacklight_config.track_search_session.storage: <%= blacklight_config.track_search_session.storage %></br>
      Prev_ID: <%= @search_context[:prev]["id"] %></br>
      Next_ID: <%= @search_context[:next]["id"] %></br>
      Document_ID: <%= @document.id %></br>
      SearchSession_ID: <%= search_session["document_id"] %></br>
      Document_ID == SearchSession_ID: <%= @document.id == search_session["document_id"] %></br>

          <%= link_back_to_catalog_safe class: 'btn btn-default button--back-to-search', label:  t('blacklight.back_to_search').html_safe %>
          <%= render(Orangelight::SearchContext::ServerItemPaginationComponent.new(search_context: @search_context, search_session: search_session, current_document: @document)) %>
      <% end %>

Example of the UI with debugging the output:

The search_session is updated with the current document.id

The search_session is not updated with the current document.id :

• Nothing seems to have changed in the Blacklight::SearchContext module and specifically in the def session

Could this be a rails change in the actionpack that handles indifferentAccess or maybe we override something in the catalog that I haven't found yet.

@sandbergja @maxkadel @rladdusaw you all worked the last 2 weeks finishing the upgrade. Did you notice a change in the search_session?

• Update1: Next step: I will look into other blacklight view components that are rendered in the page and see if they might reset the session.

• Update2: Related slack thread

• Update3: We noticed with @maxkadel that the track session configuration has changed in commit/933a5581fdd00b4d99cdd765f3e1cdc0be905f9a

• Update4: Look into search_state.reset(current_search_session.query_params)

• Update5: Loading a new instance of blacklight works as expected.

Branch with code debugging output