From fcc0c3efa2c2f0e70ee632e3bc6de8cdf28f777e Mon Sep 17 00:00:00 2001 From: Pedro Brochado Date: Fri, 5 Jul 2024 12:27:19 -0300 Subject: [PATCH] Override gemspec.mustache with dependency fixes lowerbound justification: https://github.com/lostisland/faraday/blob/main/UPGRADING.md upperbound justification: https://github.com/lostisland/faraday/releases/tag/v2.9.0 [noissue] --- gen-client.sh | 1 + templates/ruby/gemspec.mustache | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/gen-client.sh b/gen-client.sh index a0c78ac..5401c7f 100755 --- a/gen-client.sh +++ b/gen-client.sh @@ -98,6 +98,7 @@ then -o "${VOLUME_DIR}/${PACKAGE}-client" \ "--additional-properties=gemName=${PACKAGE}_client,gemLicense="GPLv2+",gemVersion=${VERSION},gemHomepage=https://github.com/pulp/${PACKAGE}" \ --library=faraday \ + -t "${VOLUME_DIR}/templates/ruby" \ --skip-validate-spec \ --strict-spec=false fi diff --git a/templates/ruby/gemspec.mustache b/templates/ruby/gemspec.mustache index ea1cf2f..8bd5d08 100644 --- a/templates/ruby/gemspec.mustache +++ b/templates/ruby/gemspec.mustache @@ -21,7 +21,9 @@ Gem::Specification.new do |s| s.metadata = {{{gemMetadata}}}{{^gemMetadata}}{}{{/gemMetadata}} {{#isFaraday}} - s.add_runtime_dependency 'faraday', '>= 1.0.1', '< 3.0' + {{! override-note: 2.0.1 lowerbound is recommended by faraday upgrade guide }} + {{! override-note: 2.9.0 upperbound is the max version below 3 that support ruby>2.6 }} + s.add_runtime_dependency 'faraday', '>= 2.0.1', '< 2.9.0' s.add_runtime_dependency 'faraday-multipart' s.add_runtime_dependency 'marcel' {{/isFaraday}}