From 615af98699d925d2062db82b353772436de55d02 Mon Sep 17 00:00:00 2001
From: Grant Gainey <ggainey@redhat.com>
Date: Tue, 15 Oct 2024 12:38:10 -0400
Subject: [PATCH] Fixed create_modulemd() stacktrace when handling malformed
 modulmd.

fixes #3756.

(cherry picked from commit 5ccddf72cc8f7a05b58941209417950d228f1549)
---
 CHANGES/3756.bugfix      |  1 +
 pulp_rpm/app/modulemd.py | 12 ++++++------
 2 files changed, 7 insertions(+), 6 deletions(-)
 create mode 100644 CHANGES/3756.bugfix

diff --git a/CHANGES/3756.bugfix b/CHANGES/3756.bugfix
new file mode 100644
index 000000000..a5700addc
--- /dev/null
+++ b/CHANGES/3756.bugfix
@@ -0,0 +1 @@
+Fixed stacktrace from create_modulemd() when trying to report an error.
diff --git a/pulp_rpm/app/modulemd.py b/pulp_rpm/app/modulemd.py
index bdb02a9f6..dbe3bd1d1 100644
--- a/pulp_rpm/app/modulemd.py
+++ b/pulp_rpm/app/modulemd.py
@@ -121,13 +121,13 @@ def create_modulemd(modulemd, snippet):
                     "Got unexpected data for module {}-{}-{}-{}-{}: "
                     "profiles failed to parse properly"
                 ).format(
-                    data[PULP_MODULE_ATTR.NAME],
-                    data[PULP_MODULE_ATTR.STREAM],
-                    data[PULP_MODULE_ATTR.VERSION],
-                    data[PULP_MODULE_ATTR.CONTEXT],
-                    data[PULP_MODULE_ATTR.ARCH],
+                    new_module[PULP_MODULE_ATTR.NAME],
+                    new_module[PULP_MODULE_ATTR.STREAM],
+                    new_module[PULP_MODULE_ATTR.VERSION],
+                    new_module[PULP_MODULE_ATTR.CONTEXT],
+                    new_module[PULP_MODULE_ATTR.ARCH],
                 )
-                log.warn(msg)
+                log.warning(msg)
             else:
                 profiles[name] = rpms