Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow marking resources as not supported #1820

Open
flostadler opened this issue Nov 12, 2024 · 0 comments
Open

Allow marking resources as not supported #1820

flostadler opened this issue Nov 12, 2024 · 0 comments
Labels
kind/engineering Work that is not visible to an external user kind/enhancement Improvements or new features

Comments

@flostadler
Copy link
Contributor

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

In some cases (like #1819), CloudFormation incorrectly labels a resource as supported (visibility = PUBLIC, provisioning-type = FULLY_MUTABLE) even though they are not.
In such cases we essentially include a broken resource in the provider.

We should add the ability to mark certain resources as not supported and overwrite CloudFormations results with that here:

out, err := cfn.ListTypes(ctx.Background(), &cloudformation.ListTypesInput{
Visibility: "PUBLIC",
ProvisioningType: provisioningType,
NextToken: nextToken,
})

Affected area/feature

@flostadler flostadler added kind/engineering Work that is not visible to an external user kind/enhancement Improvements or new features labels Nov 12, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Nov 12, 2024
@flostadler flostadler removed the needs-triage Needs attention from the triage team label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants