Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle CDK resources with physical names #152

Open
corymhall opened this issue Aug 22, 2024 · 0 comments
Open

Handle CDK resources with physical names #152

corymhall opened this issue Aug 22, 2024 · 0 comments
Assignees
Labels
kind/enhancement Improvements or new features
Milestone

Comments

@corymhall
Copy link
Contributor

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

CDK and Pulumi handle resource naming differently. There are two naming scenarios for CDK:

  1. Resources with an optional name property where CloudFormation will auto-name the resource.
  • This maps perfectly to Pulumi's autoNaming feature.
  1. Resource with a required name property. In most of these case CDK will use its own auto-naming strategy to populate the name property. During translation to Pulumi this leads to a hard coded name on the pulumi resource.

For the second scenario instead of populating the CDK hardcoded name, we should let Pulumi auto-name it. We still need to let users provide hardcoded names though.

One way we could accomplish this would be to inspect each construct and if it is a Resource then we can check to see if it has an unresolved physicalName defined. This means that it is generated by CDK (a value provided by the user would be a resolved value)

Affected area/feature

@corymhall corymhall added the kind/enhancement Improvements or new features label Aug 22, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Aug 22, 2024
@flostadler flostadler removed the needs-triage Needs attention from the triage team label Aug 22, 2024
@mjeffryes mjeffryes added this to the 0.113 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

5 participants