Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove skeleton.css #23

Open
abea opened this issue Aug 20, 2019 · 1 comment
Open

Remove skeleton.css #23

abea opened this issue Aug 20, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@abea
Copy link

abea commented Aug 20, 2019

It's not clear what Skeleton is being used for, other than styling raw elements. The effect is that it clouds pattern library project styles since elements are effected by this broad style application. It doesn't look from an initial review that we're using the Skeleton classes, but I could be missing something.

If we're not using the classes then it seems we'd be better off to remove this.

CC @grdunn @bgantick

@abea abea added the enhancement New feature or request label Aug 20, 2019
@grdunn
Copy link
Contributor

grdunn commented Aug 20, 2019

I think in an earlier version of the module, it was more heavily influenced by Skeleton. I think we can certainly get rid of it at this point, and include a more stripped down .scss/version for handling styling of the headers and title treatments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants