Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-1688) Upgrade rubocop to ~> 1.50.0 #367

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

LukasAud
Copy link
Contributor

Following a recent team decision, we are implementing a Rubocop Upgrade, moving the version from 1.48.1 to 1.50.0. This should be the final version until Puppet 7 is unsupported.

@LukasAud LukasAud requested a review from a team as a code owner January 23, 2024 15:11
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (736916b) 11.69% compared to head (3b55453) 11.69%.

Files Patch % Lines
...pet-languageserver/manifest/definition_provider.rb 0.00% 4 Missing ⚠️
...ppet-languageserver/manifest/signature_provider.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #367   +/-   ##
=======================================
  Coverage   11.69%   11.69%           
=======================================
  Files          92       92           
  Lines       11499    11499           
=======================================
  Hits         1345     1345           
  Misses      10154    10154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Following a recent team decision, we are implementing a Rubocop Upgrade,
moving the version from 1.48.1 to 1.50.0. This should be the final
version until Puppet 7 is unsupported.
@jordanbreen28 jordanbreen28 force-pushed the CAT-1688-Upgrade_rubocop branch from 56820c5 to 3b55453 Compare January 23, 2024 16:29
@david22swan david22swan merged commit 926af00 into main Jan 24, 2024
13 of 14 checks passed
@david22swan david22swan deleted the CAT-1688-Upgrade_rubocop branch January 24, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants