ENH: Add clear capability to overload logger_warning #2025
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2025 +/- ##
=======================================
Coverage 94.07% 94.08%
=======================================
Files 33 33
Lines 7077 7083 +6
Branches 1413 1414 +1
=======================================
+ Hits 6658 6664 +6
Misses 262 262
Partials 157 157
☔ View full report in Codecov by Sentry. |
|
@MartinThoma all yours 🙂 |
MartinThoma
changed the title
|
I think / hope that we don't need this. I think the logging module provides the necessary options 🤞 I want to get feedback about #2020 (comment) and put this
on-hold
|
MartinThoma
added
the
on-hold
|
Thank you for proposing a PR 🙏 In the discussion of #2020 it seems as if the issue can be solved with For this reason, I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2020