-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orientation of simplicial complexes #358
Comments
We can work around this issue by replacing the attributes of existing simplices instead of updating/extending them. If we go that round, we should make this change consistently across all complexes though. |
@ffl096 what do you mean across all complexes ? how do we make sense of orientation of combinatorial complexes? I think the difference is not trivial. Even for simplicial complex, having orientation per simplex is an assumption and abstract simplicial complexes do not come with orientation on each simplex by default. Orientation is only defined when one needs to define a matrix rep for the boundary operator. I suggest the following : create a class called OrientedSimplex, and OrientedSimplicialComplex, what do you think? |
I didn't say that combinatorial complexes have an orientation. However, if we go the route of replacing vs. updating attributes, this change should be made across all complexes, even though the need only arises for (oriented) simplicial complexes.
No. There is no harm in having an orientation-aware simplicial complex even though you don't make use of orientation as an user. Maintaining both would be a nightmare. |
The Problem
Simplicial complexes are often used with an arbitrary reference orientation in mind, e.g., when considering edge flows. Consider this simple example:
The user should expect that the edge
(2, 1)
is added with exactly this orientation, i.e., with an edge flow of10
from node2
to node1
. However, TopoNetX does not handle orientation, it transforms the edge into canonical form(1, 2)
without any thought about associated data that might be orientation-aware.Possible Actions
SimplicialComplex.add_simplex
calls are only allowed for pre-sorted tuples.The text was updated successfully, but these errors were encountered: