Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting algorithm in calendar.search does not tolerate upper-case attribute names #352

Closed
tobixen opened this issue Dec 1, 2023 · 2 comments

Comments

@tobixen
Copy link
Member

tobixen commented Dec 1, 2023

Ref #351, attn @ArtemIsmagilov

I see that in the test code, attributes are passed in lower case rather than upper case. The whole sorting algorithm should be refactored, as it's using the vobject library rather than the icalendar library, eventually all internal usage of vobject should be removed at some point. Anyway, could you confirm that replacing 'DTSTART' with 'dtstart' would solve your sorting issue?

@ArtemIsmagilov
Copy link
Contributor

Yes, it is!

@tobixen
Copy link
Member Author

tobixen commented Dec 1, 2023

This is a bug that should be fixed, so we leave the issue open.

@tobixen tobixen changed the title Sorting algorithm in calendar.search should be refactored. Sorting algorithm in calendar.search does not tolerate upper-case attribute names Dec 1, 2023
tobixen added a commit that referenced this issue Dec 8, 2023
…r. More test code is needed, since this refactoring may break things.
tobixen added a commit that referenced this issue Dec 8, 2023
* refactored some usage of vobject into icalendar.
* lots more test code for the sorting
* fixed some corner cases where sorting would throw a runtime error
* creating a task with some explicit status set didn't work
github-merge-queue bot pushed a commit that referenced this issue Dec 8, 2023
* refactored some usage of vobject into icalendar.
* lots more test code for the sorting
* fixed some corner cases where sorting would throw a runtime error
* creating a task with some explicit status set didn't work
@tobixen tobixen closed this as completed Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants