-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sorting algorithm in calendar.search
does not tolerate upper-case attribute names
#352
Comments
Yes, it is! |
This is a bug that should be fixed, so we leave the issue open. |
tobixen
changed the title
Sorting algorithm in
Sorting algorithm in Dec 1, 2023
calendar.search
should be refactored.calendar.search
does not tolerate upper-case attribute names
tobixen
added a commit
that referenced
this issue
Dec 8, 2023
…r. More test code is needed, since this refactoring may break things.
tobixen
added a commit
that referenced
this issue
Dec 8, 2023
* refactored some usage of vobject into icalendar. * lots more test code for the sorting * fixed some corner cases where sorting would throw a runtime error * creating a task with some explicit status set didn't work
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 8, 2023
* refactored some usage of vobject into icalendar. * lots more test code for the sorting * fixed some corner cases where sorting would throw a runtime error * creating a task with some explicit status set didn't work
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Ref #351, attn @ArtemIsmagilov
I see that in the test code, attributes are passed in lower case rather than upper case. The whole sorting algorithm should be refactored, as it's using the
vobject
library rather than theicalendar
library, eventually all internal usage ofvobject
should be removed at some point. Anyway, could you confirm that replacing'DTSTART'
with'dtstart'
would solve your sorting issue?The text was updated successfully, but these errors were encountered: