Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_dtend is missing #356

Open
tobixen opened this issue Dec 10, 2023 · 1 comment
Open

set_dtend is missing #356

tobixen opened this issue Dec 10, 2023 · 1 comment
Milestone

Comments

@tobixen
Copy link
Member

tobixen commented Dec 10, 2023

There is a get_dtend which is an alias to get_due, but no equivalent set_dtend.

Those convinience-mehods are going to be moved to the icalendar library, but will still live in the caldav library for many years to come due to backward-compatibility. Better have it consistent, even if those methods will soon be considered "legacy`" and "deprecated".

@tobixen
Copy link
Member Author

tobixen commented Jan 15, 2024

  • set_duration and set_due needs to be moved up to the base class
  • methods needs to be rewritten to use DTEND rather than DUE when applicable
  • It's not sufficient to do set_dtend = set_due as the named parameter due should be replaced with dtend
  • It's needed with test code

@tobixen tobixen added this to the v.1.x milestone Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant