Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some server needs explicit event or task when doing search #401

Open
tobixen opened this issue Jun 7, 2024 · 1 comment
Open

Some server needs explicit event or task when doing search #401

tobixen opened this issue Jun 7, 2024 · 1 comment
Milestone

Comments

@tobixen
Copy link
Member

tobixen commented Jun 7, 2024

  • DAViCal seems not to yield results at all if doing a query that includes search filters but does not specify if we want events, tasks or journals.
  • calendar.mail.ru will yield a 400 Bad Request-error when doing a query that does not specify if we want events or tasks (or journals), including the query "give me everything on the calendar" and "give me the object with the specified UID".

The test framework already supports DAViCal, and there is a hack in the object_by_uid-method to support DAViCal, but the behaviour from calendar.mail.ru is not very well supported.

Tasks:

  • The object_by_uid-method already has some fallback functionality when nothing is found (supporting for DAViCal), make sure the same fallback functionality works when 400 Bad Request is returned from the calendar server
  • I have for a long time had in mind that the user could give hints on what server one is connecting to when creating the client object. The idea is that the library can apply various workarounds dependent on the calendar server. In this case it would mean always passing the "event"-flag when doing searches on calendar.mail.ru, and to do separate searches for events and tasks on DAViCal and combine the results.
  • The idea above should probably wait until after 1.3.10 has been released. In the meanwhile the test libary should be hacked up so that it works towards calendar.mail.ru
@tobixen
Copy link
Member Author

tobixen commented Jun 8, 2024

For calendar.mail.ru, calendar.objects() will just throw a NotFoundError, even if calendar.events() yields results.

I'll work around it with a compatibility hook in the test code, but the proper solution depends on #402

tobixen added a commit that referenced this issue Oct 26, 2024
* Partial workaround for #401 - some servers require comptype in the search query
* At least one bugfix, possibly fixing #399 - the `accept_invite`-method not working

The work got a bit stubbed as the test account stopped working.

#403
@tobixen tobixen added this to the v1.5.0 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant