Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we pin zeroconf to 0.17 elsewhere #12

Open
barentine opened this issue Aug 7, 2020 · 1 comment
Open

we pin zeroconf to 0.17 elsewhere #12

barentine opened this issue Aug 7, 2020 · 1 comment

Comments

@barentine
Copy link
Member

version: {{ GIT_DESCRIBE_TAG }} #"0.17.7"

I'm very much in favor of updating, but there's a signature change on service info. I'll happily test/sub a PR to python-microscopy/python-microscopy for the latest zeroconf, but the latest is py3 only so let me know if that's OK at this point.

@David-Baddeley
Copy link
Contributor

I'd like to avoid a signature change / moving to a py3 only version for now. Feels like this is something we can happily keep at an older version, at least until everything else is working well. In terms of recipes, it doesn't hurt to build newer versions as long as we have a pin (if needed) in pyme-depends. I think the rationale here might have been that we already had 0.17.x in the channels so we don't need to rebuild it. Think I've done 1.18 and 1.19 successfully this way, but also suspect those are now pretty out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants