Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various minor things #310

Open
jakkdl opened this issue Oct 30, 2024 · 0 comments
Open

Various minor things #310

jakkdl opened this issue Oct 30, 2024 · 0 comments

Comments

@jakkdl
Copy link
Member

jakkdl commented Oct 30, 2024

  1. I thought it was somewhat doomed to use ruff+flake8-async, but after way too long stumbled upon https://docs.astral.sh/ruff/settings/#lint_external We should probably suggest using this in docs.

  2. flake8 --per-file-ignores works with our 5-character error codes... for now. We should add a test to see when they get around to running validation on it and break compatibility in another way.

    • I also started looking at adding an --per-file-disable to get around it and for running as standalone, and it should be fairly doable
  3. should add an example on how to run flake8-async through flake8 in pre-commit.

  4. fix visitor102: https://github.com/python-trio/flake8-async/pull/307/files#diff-4852409e79e4eb0f3736b0d3c6b6bfd8c2a14411b92416bc203a387dd6986829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant