Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing spec update: core concepts and definitions #31

Closed
5 tasks done
carljm opened this issue Jun 17, 2024 · 4 comments
Closed
5 tasks done

Typing spec update: core concepts and definitions #31

carljm opened this issue Jun 17, 2024 · 4 comments
Labels

Comments

@carljm
Copy link
Member

carljm commented Jun 17, 2024

Hello! I'd like to request formal typing council consideration of python/typing#1743, which adds to the typing spec a presentation of the core concepts of the Python type system, defines a number of key terms, and attempts to update the spec to use those terms consistently. The pull request has received excellent and thorough review from many members of the typing council and typing community.

I started a Discourse thread at https://discuss.python.org/t/formalizing-core-definitions-in-the-typing-spec/54785 -- it received a number of likes, but no replies.

TC sign off:

  • Carl
  • Eric
  • Jelle
  • Rebecca
  • Shantanu
@erictraut
Copy link
Collaborator

@carljm, thanks again for driving this change! I thoroughly read an earlier draft and have been trying to follow all of the subsequent updates, but I'd like to read the final draft from top to bottom before signing off. It may be a few days before I have time to complete this review.

@erictraut
Copy link
Collaborator

I completed my top-to-bottom review. I left a few comments for very minor suggestions, but I'm fine if these are ignored or deferred to a subsequent PR. I've signed off on the change.

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Jun 20, 2024

This is excellent, thank you for improving this!

(One minor process nit is that changes like this should probably be their own PR, even if uncontroversial)

@carljm
Copy link
Member Author

carljm commented Jun 20, 2024

Thanks all for the reviews! Per the documented process, I'll wait to merge the PR until a week has passed since I filed this issue.

@carljm carljm closed this as completed Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants