Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the vacant space around twitter widget #23

Open
realslimshanky opened this issue Jul 9, 2017 · 11 comments
Open

Fixing the vacant space around twitter widget #23

realslimshanky opened this issue Jul 9, 2017 · 11 comments

Comments

@realslimshanky
Copy link
Member

Current implementation of the twitter widget leaves unnecessary space to the left and right also it doesn't go with the theme. A solution is required by going through this comment on the original issue -> Here

@amitsin6h
Copy link
Contributor

I guess we can add facebook and instagram plugin to fill the gap. @realslimshanky If you suggest i can add.

@CuriousLearner
Copy link
Member

@amitsin6h Facebook and Instagram plugins are not needed.

As @realslimshanky pointed out, we need to get rid of the extra whitespace in the current integration of Twitter plugin.

The comment indicates this link: https://github.com/jasonmayes/Twitter-Post-Fetcher

@amitsin6h
Copy link
Contributor

@CuriousLearner that link was great help. Got it will be working to fix soons once blog integration #22 gets closed

@amitsin6h
Copy link
Contributor

@CuriousLearner @realslimshanky I have used the twitter post fetcher to fix the vacant space arround the twitter widget. we can also customize it according to our need. Please review and let me know I'll be waiting for reply

b040de5

@ashwamegh
Copy link

@CuriousLearner @realslimshanky Should I add a background image to fill the vacant space.

amitsin6h added a commit to amitsin6h/inpycon2017 that referenced this issue Jul 14, 2017
@amitsin6h
Copy link
Contributor

@CuriousLearner @realslimshanky am unable to make pull request for FIX#23

@realslimshanky
Copy link
Member Author

@shashank7200, @amitsin6h has already made a PR regarding this issue.
@amitsin6h what's the error you are getting?

@amitsin6h
Copy link
Contributor

@realslimshanky someone asked me to make pull request for every fix that I make and due to this I had deleted my old repo just to make PR for every fix but that didn't worked again. after reading more about GitHub I came to know my PR are going from the commit messages. everything clear for now no issues. Thanks for replying. also check my blog integration fix and review it .

@realslimshanky
Copy link
Member Author

@amitsin6h, you cannot create multiple PR on the same repo. Once you've made one PR all your future commits will be appended to you first PR. You need to rebase your local repo to the point where you added integration for the blog and then create a fresh PR. This is the only clean way to go IMHO after seeing #22

@CuriousLearner
Copy link
Member

@realslimshanky Nope.

@amitsin6h What you need is to make separate branches for each PR. That way the branches like master on your fork would remain clean.

Each branch solves one issue and corresponds to one PR. As soon as you get some review, you do the work in that branch and the corresponding PR updates.

This is the way all the changes remain isolated.

You can read about DVCS git on git-scm.com

I hope that helps :)

@realslimshanky
Copy link
Member Author

@amitsin6h sorry I meant to say should not. There was a lot of confusion on the first PR itself.

amitsin6h added a commit to amitsin6h/inpycon2017 that referenced this issue Jul 18, 2017
amitsin6h added a commit to amitsin6h/inpycon2017 that referenced this issue Jul 23, 2017
amitsin6h added a commit to amitsin6h/inpycon2017 that referenced this issue Aug 3, 2017
amitsin6h added a commit to amitsin6h/inpycon2017 that referenced this issue Aug 3, 2017
amitsin6h added a commit to amitsin6h/inpycon2017 that referenced this issue Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants