[2/x] float8 cleanup: move roofline utils to testing #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1780
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vkuzo
added a commit
that referenced
this pull request
Feb 25, 2025
Summary: Moves `torchao/float8/roofline_utils.py` to `torchao/testing/float8`, as this is only needed for tests/benchmarks. Test Plan: ``` python benchmarks/float8/float8_roofline.py ~/local/tmp/20250223_test ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 92b3a33aa8936bafed303bd954408c5e8ee6f632 ghstack-comment-id: 2683402019 Pull Request resolved: #1780
facebook-github-bot
added
the
CLA Signed
vkuzo
added
the
topic: not user facing
jainapurva
approved these changes
Feb 25, 2025
danielvegamyhre
approved these changes
Feb 25, 2025
vkuzo
added a commit
that referenced
this pull request
Feb 26, 2025
Summary: Moves `torchao/float8/roofline_utils.py` to `torchao/testing/float8`, as this is only needed for tests/benchmarks. Test Plan: ``` python benchmarks/float8/float8_roofline.py ~/local/tmp/20250223_test ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 8bfadd4a6a6e96d0d2c3175aa94279ac015fe18e ghstack-comment-id: 2683402019 Pull Request resolved: #1780
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Moves
torchao/float8/roofline_utils.pytotorchao/testing/float8, asthis is only needed for tests/benchmarks.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: