-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roofline estimator: simplify #1783
Open
vkuzo
wants to merge
3
commits into
gh/vkuzo/44/head
Choose a base branch
from
gh/vkuzo/45/head
base: gh/vkuzo/44/head
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1783
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e9ab762 with merge base 1ab1b77 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Feb 26, 2025
vkuzo
added a commit
that referenced
this pull request
Feb 26, 2025
Summary: 1. remove estimating torch.compile limitations (interesting but hasn't been useful) 2. make clearer distinction between roofline and benchmarked values Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 3348fff4abce61a52265e94badbe58426bd342ab ghstack-comment-id: 2683886949 Pull Request resolved: #1783
vkuzo
added a commit
that referenced
this pull request
Feb 26, 2025
Summary: 1. remove estimating torch.compile limitations (interesting but hasn't been useful) 2. make clearer distinction between roofline and benchmarked values 3. sympy float -> float cast to fix pandas df formatting Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: dacab7f909eb7214a25a068d7d6ebc9a12a7614d ghstack-comment-id: 2683886949 Pull Request resolved: #1783
jerryzh168
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
topic: not user facing
Use this tag if you don't want this PR to show up in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
been useful)
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: