Skip registration for files and ignore files with insufficient rights #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KochTobi
previously approved these changes
May 29, 2024
| private List<RegistrationRequest> createRequests(File[] files, Path userDirectory) { | ||
| if (files == null || files.length == 0) { | ||
| return new ArrayList<>(); | ||
| } | ||
| return Arrays.stream(files).filter(file -> !file.isHidden()) | ||
| return Arrays.stream(files).filter(file -> !file.isHidden()).filter(File::isDirectory) |
There was a problem hiding this comment.
I would argue that the filtering for directories should take place earlier. In the detectDataForRegistration there is a variable userProcessDirectories containing both files that are and file that are not directories?
Why is the check in line 74 not sufficient?
There was a problem hiding this comment.
Good point!
I added another filter method and apply all filters before the createRequest method, since it violates the definition of a function.
…m:qbicsoftware/data-processing into fix/registration-data-must-be-a-directory
KochTobi
reviewed
May 29, 2024
| if (file.isHidden()) { | ||
| return false; | ||
| } | ||
| return !file.isFile(); |
There was a problem hiding this comment.
Suggested change
| return !file.isFile(); | |
| return file.isDirectory(); |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the registration fails silently if the dataset to register
is not wrapped in a directory.
Also, the dataset registration fails, when the application has not sufficient rights to execute and write to the dataset folder (e.g. wrong access group, etc).