Hotfix - suffix not working (#71)

* This PR introduces a hotfix for the --suffix filtering not working.
qbicsoftware · Sep 17, 2020 · 87bd3e1 · 87bd3e1
1 parent d2fbdbb
commit 87bd3e1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## Hotfix 0.4.1
+
+* Fix the issue of not finding datasets when filtering by suffix
+
 ## Release 0.4.0
 
 * Calculate CRC32 checksums for every downloaded file and compares it against the sum stored in openBIS

diff --git a/pom.xml b/pom.xml
@@ -9,7 +9,7 @@
         <version>2.2.0</version>
     </parent>
     <artifactId>postman-cli</artifactId>
-    <version>0.4.0</version>
+    <version>0.4.1</version>
     <name>Postman cli</name>
     <url>http://github.com/qbicsoftware/postman-cli</url>
     <description>A client software written in Java for dataset downloads from QBiC's data management system openBIS </description>

diff --git a/src/main/java/life/qbic/model/download/QbicDataFinder.java b/src/main/java/life/qbic/model/download/QbicDataFinder.java
@@ -125,6 +125,7 @@ public List<DataSetFile> findAllRegexFilteredIDs(String ident, List<String> rege
    */
   public List<DataSetFile> findAllSuffixFilteredIDs(String ident, List<String> suffixes) {
     List<DataSet> allDatasets = findAllDatasetsRecursive(ident);
+
     List<DataSetFile> allFileIDs = new ArrayList<>();
 
     for (DataSet ds : allDatasets) {
@@ -141,7 +142,7 @@ public List<DataSetFile> findAllSuffixFilteredIDs(String ident, List<String> suf
       // remove everything that doesn't match the suffix -> only add if suffix matches
       for (DataSetFile file : files) {
         for (String suffix : suffixes) {
-          if (StringUtil.endsWithIgnoreCase(file.getPermId().toString(), suffix)) {
+          if (StringUtil.endsWithIgnoreCase(file.getPath(), suffix)) {
             filesFiltered.add(file);
           }
         }