Reorganize buttons of the "Transform Mesh Vertices" dialog

[DelazJ]

Feature description

Among changes brought by #58877 there is ability to assign Z value using the terrain as shown below

I find this GUI confusing due to the "Get Z value from project terrain" placement. Putting it (that big) at the end of the dialog lets think that it is the main purpose of the dialog, while it is just another way to fill the Z value.

I'd suggest to add it as a "tooltiped" icon next to the Z value textbox and it should probably be greyed out like other buttons until Z checkbox is hit.
That way, the "Preview transform" and "Apply transform" buttons will get back their importance in the dialog

Additional context

No response

[JanCaha]

The issue is, that hitting this button will immediately assign Z values to the Mesh, no preview or anything. Also the Z value text box is used to set fixed or dynamic (calculated) value. But this does something different it extracts Z value from another source and assign it to the Mesh. Maybe there could be a label above the the button with some slight description? Or the button could be wrapped into Group box with some descriptive name?

Feel free to suggest the label or the name for the group box.

[DelazJ]

@JanCaha thanks for feedback and explanation

The issue is, that hitting this button will immediately assign Z values to the Mesh, no preview or anything.

Why? Should it? I'm quite confused. The initial purpose of this dialog (from my understanding) is to be able to modify the xyz coords of vertices using a fixed value or an expression and hitting "apply transform". Now the dialog also allows to change the Z only directly. So we have two different buttons to leave that dialog?
if I want to change the XY using expression and the Z from the terrain, is that possible in one go? Or should I do xy changes, press transform then press Z from terrain (or in the reverse order)?
Sticking to my initial suggestion, what about using a push button (or another checkbox?) on the Z row or just below? As long as it is ON, we apply the Z from terrain to the vertex when "apply transform" is hit? Perhaps should it grey out also the Z text field and expression button to show that it takes precedence and visually notify what Z is being used.
The tooltip on that button should also clarify whether Z is taken from origin x,y position or destination x,y position.

Maybe there could be a label above the the button with some slight description?

Yes tooltips are always welcome.

Or the button could be wrapped into Group box with some descriptive name?

According to guidelines, group boxes with single button are not really welcome.

[JanCaha]

So we have two different buttons to leave that dialog?

Not two buttons to leave the dialog, but two actions to do using the dialog. At least that is my view. The action under the button is completely separate. We searched and discussed a bit where this button should be placed and decided that this panel would be best option.

if I want to change the XY using expression and the Z from the terrain, is that possible in one go? Or should I do xy changes, press transform then press Z from terrain (or in the reverse order)?

The Apply Transform and Get Z values from project terrain are not tied in any way, you can use them in any order you like.

Sticking to my initial suggestion, what about using a push button (or another checkbox?) on the Z row or just below?

In my opinion the coordinates editing is already complex as it is. I do not like idea of making it even more complicated. Also as mentioned previously this is a separate tool, which is not directly linked to that process.

How about adding a horizontal line after the current Preview and Apply buttons to split from the previously existing tools and adding a reasonable "heading" above to introduced button to emphasize that this is other part of the dialog.

Let me ping @uclaros who helped me to put this together.