From 4079a4f354834af93fd1a033e7cfdb7f22d47ef8 Mon Sep 17 00:00:00 2001 From: nighca Date: Tue, 26 Nov 2019 10:18:25 +0800 Subject: [PATCH 1/2] revert FormState disableValidationWhen behavior --- src/formState.spec.ts | 3 --- src/formState.ts | 3 --- src/types.ts | 1 - 3 files changed, 7 deletions(-) diff --git a/src/formState.spec.ts b/src/formState.spec.ts index 1053357..e6feb68 100644 --- a/src/formState.spec.ts +++ b/src/formState.spec.ts @@ -871,19 +871,16 @@ describe('FormState (mode: array) validation', () => { runInAction(() => options.disabled = true) await state.validate() - expect(state.$[0].hasError).toBe(false) expect(state.hasError).toBe(false) expect(state.error).toBeUndefined() state.$[0].onChange('') await state.validate() - expect(state.$[0].hasError).toBe(false) expect(state.hasError).toBe(false) expect(state.error).toBeUndefined() runInAction(() => options.disabled = false) await delay() - expect(state.$[0].hasError).toBe(true) expect(state.hasError).toBe(true) expect(state.error).toBe('empty') diff --git a/src/formState.ts b/src/formState.ts index ccbe210..c5bba44 100644 --- a/src/formState.ts +++ b/src/formState.ts @@ -239,9 +239,6 @@ export default class FormState boolean) { this.shouldDisableValidation = predict - this.fields.forEach( - field => field.disableValidationWhen(predict) - ) return this } diff --git a/src/types.ts b/src/types.ts index 86a75f1..d0a7d71 100644 --- a/src/types.ts +++ b/src/types.ts @@ -49,7 +49,6 @@ export interface ComposibleValidatable extends Validatable boolean) => this } /** Function to do dispose. */ From 2a9c149998d0efced19c7a22ef56dd26cc0a5e8b Mon Sep 17 00:00:00 2001 From: nighca Date: Tue, 26 Nov 2019 10:19:14 +0800 Subject: [PATCH 2/2] v1.0.5 --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index b4344bf..751a2be 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "formstate-x", - "version": "1.0.4", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 4153776..09e30db 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "formstate-x", - "version": "1.0.4", + "version": "1.0.5", "description": "Extended alternative for formstate", "repository": { "type": "git",