Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm release fails due to release commit message not conforming to conventional commit #345

Closed
mrloop opened this issue Dec 19, 2023 · 2 comments

Comments

@mrloop
Copy link
Contributor

mrloop commented Dec 19, 2023

See cli output here

โžœ  ember-lottie git:(main) pnpm release

> [email protected] release /home/ewan/projects/qonto/ember-lottie
> release-it


๐Ÿš€ Let's release ember-lottie (1.0.0...1.0.1)


Changelog:
## [1.0.1](https://github.com/qonto/ember-lottie/compare/v1.0.0...v1.0.1) (2023-12-19)

### Bug Fixes
* dont pass undefined options to fetch ([78e36d4](https://github.com/qonto/ember-lottie/commit/78e36d44e152679c6a5d8d0974576995243eaf20))
* update broken lockfile ([786b705](https://github.com/qonto/ember-lottie/commit/786b7057320ef398566edf63933272a412ad907c))


Changeset:
 M CHANGELOG.md
 M ember-lottie/package.json
 M package.json
 M test-app/package.json

? Commit (Release 1.0.1)? Yes
ERROR Error: โ•ญโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ•ฎ
โ”‚ ๐ŸฅŠ lefthook v1.5.5  hook: commit-msg โ”‚
โ•ฐโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ•ฏ
โ”ƒ  commitlint โฏ

โง—   input: Release 1.0.1
โœ–   subject may not be empty [subject-empty]
โœ–   type may not be empty [type-empty]

โœ–   found 2 problems, 0 warnings
โ“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint


exit status 1
  โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€
summary: (done in 0.60 seconds)
๐ŸฅŠ  commitlint
Rolling back changes...
Resetting local changes made
โ€‰ELIFECYCLEโ€‰ Command failed with exit code 1.
@mrloop
Copy link
Contributor Author

mrloop commented Jan 3, 2024

Does #333 fix this? Can this issue be closed? @michelegera

@michelegera
Copy link
Contributor

Does #333 fix this? Can this issue be closed? @michelegera

Indeed it does ๐Ÿ™‚
Now releases are delegated to the CI, and the release commit message conforms to CC standards. Closing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants