New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Signature drift between NewPush and NewPull #22

Open

b5 opened this issue Sep 5, 2019 · 0 comments

Labels

Member

b5 commented Sep 5, 2019

// Pull now accepts a meta param
NewPull(cidStr string, lng ipld.NodeGetter, bapi coreiface.BlockAPI, rem DagSyncable, meta map[string]string) (pull *Pull, err error)

// Push doesn't...
func NewPush(lng ipld.NodeGetter, info *dag.Info, remote DagSyncable, pinOnComplete bool) (*Push, error)

I think we should pull the meta param off of pull, and use the form that push uses: a SetMeta method on the push itself.

The text was updated successfully, but these errors were encountered:

b5 added the refactor label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment