Support multiscale images; specify output size #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IrisRainbowNeko
changed the title
quantum5
requested changes
Feb 8, 2025
Comment on lines
53
to
+64
| if args.scale: | ||
| scale.apply_to_frames(cursor.frames, scale=args.scale) | ||
| scales = eval(args.scale) | ||
| if isinstance(scales, (int, float)): | ||
| scale.apply_to_frames(cursor.frames, scale=scales) | ||
| else: | ||
| cursor.frames = scale.apply_to_frames_MS(cursor.frames, scales=scales) | ||
| elif args.size: | ||
| sizes = eval(args.size) | ||
| if isinstance(sizes, (int, float)): | ||
| scale.apply_to_frames(cursor.frames, size=sizes) | ||
| else: | ||
| cursor.frames = scale.apply_to_frames_MS(cursor.frames, sizes=sizes) |
There was a problem hiding this comment.
Please do not use eval. This is a security nightmare when using this in any form of automation.
Comment on lines
39
to
+50
| if args.scale: | ||
| scale.apply_to_frames(cursor.frames, scale=args.scale) | ||
| scales = eval(args.scale) | ||
| if isinstance(scales, (int, float)): | ||
| scale.apply_to_frames(cursor.frames, scale=scales) | ||
| else: | ||
| cursor.frames = scale.apply_to_frames_MS(cursor.frames, scales=scales) | ||
| elif args.size: | ||
| sizes = eval(args.size) | ||
| if isinstance(sizes, (int, float)): | ||
| scale.apply_to_frames(cursor.frames, size=sizes) | ||
| else: | ||
| cursor.frames = scale.apply_to_frames_MS(cursor.frames, sizes=sizes) |
| cursor.hotspot = (int(hx * scale), int(hy * scale)) | ||
|
|
||
|
|
||
| def apply_to_frames_MS(frames: List[CursorFrame], *, scales: List[float] = None, |
There was a problem hiding this comment.
What is _MS? Use a more sensible name.
Comment on lines
+23
to
+32
| if scales is not None: | ||
| for scale in scales: | ||
| frames_s = [frame.clone() for frame in frames] | ||
| apply_to_frames(frames_s, scale=scale) | ||
| frames_MS.extend(frames_s) | ||
| else: | ||
| for size in sizes: | ||
| frames_s = [frame.clone() for frame in frames] | ||
| apply_to_frames(frames_s, size=size) | ||
| frames_MS.extend(frames_s) |
There was a problem hiding this comment.
Does this need to be one function? It's basically two separate functions.
| for scale in scales: | ||
| frames_s = [frame.clone() for frame in frames] | ||
| apply_to_frames(frames_s, scale=scale) | ||
| frames_MS.extend(frames_s) |
There was a problem hiding this comment.
Why are you concatenating frames of different sizes? This is wrong. A frame contains multiple images of different sizes. When scaling an animated cursor, you keep the same number of frames, but each frame will have more images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
--scaleargument support input of multiple scales.--scale 0.25resize the cursor to 1/4 of its original size.--scale "[0.125,0.25,0.5]"resize the cursor to multiple scales and put them into one cursor file.Add
--sizeargument to support specify multiple output size.--size 32resize the cursor to 32px.--size "[32,48,64]"resize the cursor to multiple sizes and put them into one cursor file.