Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_brand.yml: google returning different font names confuses us #11947

Open
cscheid opened this issue Jan 24, 2025 · 1 comment
Open

_brand.yml: google returning different font names confuses us #11947

cscheid opened this issue Jan 24, 2025 · 1 comment
Assignees
Labels
brand `_brand.yml` bug Something isn't working
Milestone

Comments

@cscheid
Copy link
Collaborator

cscheid commented Jan 24, 2025

This works:

typography: 
  fonts:
    - source: google
      family: 'Source Sans Pro'
  base: 
    family: 'Source Sans Pro'

This doesn't:

typography: 
  fonts:
    - source: google
      family: 'Source Sans 3'
  base: 
    family: 'Source Sans 3'

Even though "Source Sans 3" is the name of the font on Google Fonts. The issue appears to be that the CSS query returns Source Sans Pro as the name of the font, but we try to use Source Sans 3, and faceplant.

@cscheid cscheid added the bug Something isn't working label Jan 24, 2025
@cscheid cscheid self-assigned this Jan 24, 2025
@cscheid cscheid added the brand `_brand.yml` label Jan 24, 2025
@cscheid cscheid added this to the v1.7 milestone Jan 24, 2025
@gordonwoodhull
Copy link
Contributor

gordonwoodhull commented Jan 25, 2025

Related to #11278 on the Typst side, which I stopgapped with some documentation because it seemed pretty rare.

But if the CSS query returns the actual font name, that's much better!

@gordonwoodhull gordonwoodhull self-assigned this Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brand `_brand.yml` bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants