Skip to content
This repository has been archived by the owner on Jan 25, 2021. It is now read-only.

Store conversion data in class attributes of UnitConvert #3

Open
goerz opened this issue May 9, 2016 · 0 comments
Open

Store conversion data in class attributes of UnitConvert #3

goerz opened this issue May 9, 2016 · 0 comments

Comments

@goerz
Copy link
Member

goerz commented May 9, 2016

The _read_units_definition method should be a class method, and all the attributes it sets class attributes.

Various classes such as UnitFloat and Pulse keep an instance of UnitConvert for internal unit conversion. In the case that a user adds new units, these should be available to all converter instances. It might also make sense to disable the possibility of having alternative internal units than au.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant