Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made a lot of changes, want me to adapt for a pull request? #27

Open
jpmhouston opened this issue Sep 1, 2015 · 1 comment
Open

Made a lot of changes, want me to adapt for a pull request? #27

jpmhouston opened this issue Sep 1, 2015 · 1 comment

Comments

@jpmhouston
Copy link

I made a lot of changes for using this with a client's app that had a mapview with tableview that slides up from the bottom:

  • allow the top view, the mapview in my case, to stay fullscreen with the bottom view above it (because resizing map view while panning scrollview looks bad, keeping it fixed size & recentering it while panning looks better)
  • allowed automatic setup from storyboard using custom segues to reference top & bottom view controllers, setting the top view controller as the delegate if it conforms to protocol
  • allowed setting height, max of bottom view instead of the top view
  • allowed setting a snap position, a threshold for snapping to this height or to max or min when panning stops
  • had problems with scrollview delegate methods, changed to have the bottom view controller just explicitly forward delegate calls to its parent view controller

I'll put what I have into a simple fork for now, but wondered if you'll be interested in taking these changes as pull requests? If so, I'll need to re-implement some of them to be based on your code as starting point rather than the experimental hack & rewrite I did.

But if some of those changes don't fit with your ideas, then I'd rather rename my fork to avoid confusion and let it live as a new cocoapod for my client's app, from which you or any of your users can back-port any of my work as desired.

Can I get your opinion?

@jpmhouston
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant