Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New context menu architecture design #453

Open
ACTCD opened this issue Mar 20, 2023 · 1 comment
Open

New context menu architecture design #453

ACTCD opened this issue Mar 20, 2023 · 1 comment
Labels
enhancement Feature work maintenance Chores and refactoring
Milestone

Comments

@ACTCD
Copy link
Collaborator

ACTCD commented Mar 20, 2023

The current @run-at content-menu is an undocumented design.

It is currently registered with all contexts and only uses a limited browser.menus.ACTION_MENU_TOP_LEVEL_LIMIT. It leads to lack of scalability, and less suitable use cases.

The top level menu should be reserved more for the functionality of the extension itself. Most registry items generated by user script should use the secondary menu.

Also, we should register different usage scenarios to different contexts, not to all contexts. Registration timing and persistence should also be considerations.

Note that the context menu should not be used as a direct replacement for GM.registerMenuCommand, it should be reimplemented in popup. Ref:#230

@ACTCD ACTCD added javascript maintenance Chores and refactoring labels Mar 20, 2023
@ACTCD ACTCD added this to the macOS 5.0.0, iOS 2.0.0 milestone Apr 2, 2023
@quoid quoid removed the javascript label May 1, 2023
@ACTCD ACTCD added the enhancement Feature work label Apr 17, 2024
@hippogryphriders

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature work maintenance Chores and refactoring
Projects
Status: To do
Development

No branches or pull requests

3 participants