Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts about combining this with quran.com-frontend repo? #104

Open
mmahalwy opened this issue May 5, 2018 · 1 comment
Open

Thoughts about combining this with quran.com-frontend repo? #104

mmahalwy opened this issue May 5, 2018 · 1 comment

Comments

@mmahalwy
Copy link
Contributor

mmahalwy commented May 5, 2018

For the most part, there are many shared components and many shared features. Also, we can have one shared webpack config. We can have it in a monorepo for the most part? Not sure. Fishing for thoughts

cc @ahmedre @sabeurthabti

@thabti
Copy link
Contributor

thabti commented May 15, 2018

This is a great idea, I've been thinking of refactoring this project ( :( no time). Would be good to use the build pipeline from quran.com.

How can we make this happen? any idea on the folder structure?
maybe the existing audio repo can hold the DB and become an API? so that the new audio repo can be stateless.

Here is my proposal of the folder structure (I've never used mono-repo)

quran-fe/
├── quran/
│   ├── server
│   ├── client
│   ├── index.js
│   └── package.json
├── audio/
│   ├── server
│   ├── client
│   ├── index.js
│   ├── package.json
│   └── audio.db (maybe db can become its own api repo)
├── common-components/
│   ├── storybook
│   ├── components
│   ├── index.js
│   └── package.json
└── core/
    ├── webpack.dev.js
    ├── webpack.prod.js
    ├── build.js
    └── tools.js

I am sure @ahmedre can shed some light on how best to work with mono-repo and their deployments. What would this mean for getting people to contribute? would it scare them away?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants