New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formatSeconds.js is unnecessarily verbose #109

Open

mustafa0x opened this issue May 25, 2018 · 1 comment

mustafa0x commented May 25, 2018

https://github.com/quran/audio.quran.com/blob/master/src/utils/formatSeconds.js

Instead the 11 lines, you can just use this:

let fmt_time = s => (new Date(s * 1000).toISOString().substr(10, 9)).replace(/T(00:)?/, '');

It's what I wrote for qari.one.

Contributor

thabti commented May 27, 2018

@mustafa0x feel free to raise a PR :)
We could do with some help. Jzkallah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment