Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JMI Uuid sorting broken because of change in Qt from 6.7 to 6.8 #659

Closed
krop opened this issue Oct 13, 2024 · 5 comments
Closed

JMI Uuid sorting broken because of change in Qt from 6.7 to 6.8 #659

krop opened this issue Oct 13, 2024 · 5 comments
Labels

Comments

@krop
Copy link
Contributor

krop commented Oct 13, 2024

tst_qxmppjinglemessageinitiationmanager fails when using Qt 6.8.0 and qxmpp 1.8.1:

[  287s] 20/64 Test #22: tst_qxmppjinglemessageinitiationmanager ....***Failed    0.02 sec
[  287s] ********* Start testing of tst_QXmppJingleMessageInitiationManager *********
[  287s] Config: Using QtTest library 6.8.0, Qt 6.8.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 14.2.1 20241007 [revision 4af44f2cf7d281f3e4f3957efce10e8b2ccb2ad3]), unknown unknown
[  287s] PASS   : tst_QXmppJingleMessageInitiationManager::initTestCase()
[  287s] PASS   : tst_QXmppJingleMessageInitiationManager::testClear()
[  287s] PASS   : tst_QXmppJingleMessageInitiationManager::testClearAll()
[  287s] PASS   : tst_QXmppJingleMessageInitiationManager::testRing()
[  287s] PASS   : tst_QXmppJingleMessageInitiationManager::testProceed()
[  287s] PASS   : tst_QXmppJingleMessageInitiationManager::testReject()
[  287s] PASS   : tst_QXmppJingleMessageInitiationManager::testRetract()
[  287s] PASS   : tst_QXmppJingleMessageInitiationManager::testFinish()
[  287s] SKIP   : tst_QXmppJingleMessageInitiationManager::testPropose() Export 'QXMPP_TESTS_INTEGRATION_ENABLED=1' to enable.
[  287s]    Loc: [/home/abuild/rpmbuild/BUILD/qxmpp-1.8.1/tests/qxmppjinglemessageinitiationmanager/tst_qxmppjinglemessageinitiationmanager.cpp(278)]
[  287s] PASS   : tst_QXmppJingleMessageInitiationManager::testSendMessage()
[  287s] FAIL!  : tst_QXmppJingleMessageInitiationManager::testHandleNonExistingSessionLowerId() Compared values are not the same
[  287s]    Actual   (jmiElement->type()): 4
[  287s]    Expected (JmiType::Retract)  : 5
[  287s]    Loc: [/home/abuild/rpmbuild/BUILD/qxmpp-1.8.1/tests/qxmppjinglemessageinitiationmanager/tst_qxmppjinglemessageinitiationmanager.cpp(357)]
[  287s] FAIL!  : tst_QXmppJingleMessageInitiationManager::testHandleNonExistingSessionHigherId() Compared values are not the same
[  287s]    Actual   (jmiElement->type()): 5
[  287s]    Expected (JmiType::Reject)   : 4
[  287s]    Loc: [/home/abuild/rpmbuild/BUILD/qxmpp-1.8.1/tests/qxmppjinglemessageinitiationmanager/tst_qxmppjinglemessageinitiationmanager.cpp(408)]
@lnjX lnjX added the type:bug label Oct 14, 2024
@lnjX
Copy link
Member

lnjX commented Oct 14, 2024

Thanks for reporting, i also experienced this and i absolutely don't understand why it fails with qt 6.7+ or something. Need to investigate further. :)

@lnjX lnjX changed the title Test failure with Qt 6.8.0 JMI Uuid sorting broken because of change in Qt from 6.7 to 6.8 Oct 21, 2024
@lnjX
Copy link
Member

lnjX commented Oct 21, 2024

The issue is that Qt 6.8 returns

"{ca3cf894-5325-482f-a412-a6e9f832298d}" < "{fecbea35-08d3-404f-9ec7-2b57c566fa74}" false

while Qt 6.7 returns

"{ca3cf894-5325-482f-a412-a6e9f832298d}" < "{fecbea35-08d3-404f-9ec7-2b57c566fa74}" true

(as expected).

    auto lowerSessionId = QUuid::fromString(u"ca3cf894-5325-482f-a412-a6e9f832298d");
    auto higherSessionId = QUuid::fromString(u"fecbea35-08d3-404f-9ec7-2b57c566fa74");
    qDebug() << lowerSessionId.toString() << "<" << higherSessionId.toString() << (lowerSessionId < higherSessionId);

I opened https://bugreports.qt.io/browse/QTBUG-130368 now. Not sure whether it's really Qt's fault since I don't see that there's a specific order given in the documentation.

lnjX added a commit that referenced this issue Oct 21, 2024
@krop
Copy link
Contributor Author

krop commented Oct 22, 2024

The issue is that Qt 6.8 returns

[cut]
I opened https://bugreports.qt.io/browse/QTBUG-130368 now. Not sure whether it's really Qt's fault since I don't see that there's a specific order given in the documentation.

Thanks, I'll retry after adding the fix for QTBUG-130155 to our Qt package

@krop
Copy link
Contributor Author

krop commented Oct 22, 2024

Thanks, I'll retry after adding the fix for QTBUG-130155 to our Qt package

Tests are fixed after backporting https://code.qt.io/cgit/qt/qtbase.git/commit/?id=222891d0b6b8 Do you want to close he report or deal with the Qt 7 warning?

@lnjX
Copy link
Member

lnjX commented Oct 22, 2024

Ah okay yeah I think we can close this as it is fixed upstream.

@lnjX lnjX closed this as completed Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants