Skip to content
This repository has been archived by the owner on Aug 4, 2022. It is now read-only.

VXRD: Comparison #27

Open
7 of 11 tasks
sabaronett opened this issue Feb 17, 2020 · 7 comments
Open
7 of 11 tasks

VXRD: Comparison #27

sabaronett opened this issue Feb 17, 2020 · 7 comments
Assignees

Comments

@sabaronett
Copy link
Collaborator

sabaronett commented Feb 17, 2020

VXRD comparison

  • Build add'l page (route) for comparing the PXRD for two structures 720cc4e
  • Add another load menu for the 2nd structure 720cc4e
  • Add the additional shiftfield in this page (default=2.0) c6d3006
  • Debug "missing 2nd file" issue 8b92166
  • Verify comparison() route works 0aaa3bb
  • Final verification of plot w/ similarity VXRD: Comparison #27 (comment)
  • Add vertically-stacked JSmol w/ 2x2 grid (plot in lower-left) a02536f
  • Create new branch "multicompare"
  • Multi-upload comparison, see VXRD: Comparison #27 (comment)
    • Show dynamic list of structures from upload2, w/ 1st defaulted
    • Allow single selection of radio list to update JSmol2 and plotly comparison

Reference

@sabaronett sabaronett self-assigned this Feb 17, 2020
@sabaronett sabaronett changed the title VXRD: Comparison (Similarity) VXRD: Comparison Feb 17, 2020
@sabaronett
Copy link
Collaborator Author

@qzhu2017
Everything should be working now as of the latest commits. I tried to recreate the conditions of your example in #26 in the screenshot below. Some of the peaks look different and the "similarity" is 0.00, but I'm not sure if that has to do with the inputs and/or similarity function.

Anyway, I encourage you to play around with it, and I'll leave the issue open for now until you can verify it's working as expected.

screenshot

@qzhu2017
Copy link
Owner

@sabaronett @sayred1

I think you did everything right. The trick is to adjust the FWHM. I tried the following setup (FWHM=1.0), it gives S=0.825.

image

@qzhu2017
Copy link
Owner

@sayred1 I suspect the shift value does not work as it is supposed to. I adjust it from 0.1 to 2. The results does not change at all.

@qzhu2017
Copy link
Owner

@sayred1 This should be some problem easy to fix. Please let me know if you get it done soon!

@qzhu2017
Copy link
Owner

@sabaronett The results seems to be good now after my commit 58dc94c

@qzhu2017 qzhu2017 mentioned this issue Feb 18, 2020
5 tasks
@sabaronett
Copy link
Collaborator Author

Great! Thanks. I'm going to close this issue for now. Feel free to reopen it if anything changes or you want to add anything.

@sabaronett
Copy link
Collaborator Author

From today's meeting:
IMG_20200305_133350

@sabaronett sabaronett reopened this Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants