-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scheme of r-hyperspec packages #5
Comments
@r-hyperspec/r-hyperspec These schemes are for discussion on Wednesday's meeting. They show how I understand our vision of r-hyperspec family (two versions of the vision are presented). Please, study and prepare your suggestions. UPDATE: I updated the schemes and moved them to the message below. The graphs are implemented with GraphViz via DiagrammeR in RStudio. Sources: r-hyperspec-schemes-GraphViz.zip Unzip, open in RStudio and press "Preview" button. Modify and press "Preview" again. |
Great job @GegznaV |
A couple of comments.
|
I corrected some issues in the schemes. LegendLegend
Lines/Arrows:
|
Here's my proposal, edited from @GegznaV's list on slack: Main package
Bridge packages... connect hyperSpec with other packages where interaction does not work automatically. They can go on CRAN since we don't need huge test data sets.
Data packages:
Helper/Utility packages:
Helper GH repos:
Input/Output packages:This is where things are more complicated... If we want to cut down dependencies (cbeleites/hyperSpec#215), at least some file import packages should go by file format rather than manufacturer:
There are import filters that do not add dependencies for binary formats:
These two file formats are sufficiently widespread and well-known that I believe they should each go into its own package. There are import filters for a large variety of ASCII/text based formats:
Should these be bundled into, say, hySpc.read.txt? Last but not least, there is a number of file formats where we have example data but no import functions yet. At least some of them will have their own dependencies.
@bryanhanson, @GegznaV , @eoduniyi, @ximeg: What do you think: It may be better to have the file import packages named consistently and have them all by file format name. |
As long as the end user can easily install all My point is that as an end user (data analyst/spectroscopist) I want to be able to
library(hySpc.ggplot2)
library(hySpc.chondro)
library(hySpc.matrixStats)
library(hySpc.baseline)
library(hySpc.read.ENVI)
library(hySpc.read.spc)
library(hySpc.read.txt)
# Now I can finally write a line of code that reads a file, subtracts a baseline, and makes a plot
...
???
# Wait, I forgot to load a package that provides the `filter()` function...
# What was its name? ... Google it... Ah, `dplyr`
library(hySpc.dplyr)
...
# works! |
vision-model@GegznaV this is still useful: io@cbeleites It sounds like the ux/ui@ximeg I totally agree with you on this; I wonder about other ways to support the friendliness/experience for typical spectroscopic work. maintainability@bryanhanson I think the documentation on functionality and contributing/style has made it easier to maintain |
From the perspective of time I think we've gotten more specific about the implementation details: @cbeleites 2011 hyperSpec figure -> RGSOC_2020 figures -> @GegznaV figures |
Closing, as we have pretty much settled on a naming scheme and the issue is old. |
For me, it is a bit unclear, where we are going to with this project and how it should look at the end of this summer. The vision in the form of a scheme/flowchart would be helpful. The scheme should contain the names of
r-hyperspec
family packages and other non-package repositories we are going to create and the dependencies between them. The scheme may change later.And I'm preparing a draft scheme which could be a starting point for the discussion.
The text was updated successfully, but these errors were encountered: