Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release seems to have started ignoring new_device=FALSE #234

Closed
luca850 opened this issue Jan 20, 2025 · 3 comments · Fixed by #235
Closed

Latest release seems to have started ignoring new_device=FALSE #234

luca850 opened this issue Jan 20, 2025 · 3 comments · Fixed by #235

Comments

@luca850
Copy link

luca850 commented Jan 20, 2025

Latest release seems to have started ignoring new_device=FALSE.
I've not had an issue with previous versions.

@hadley
Copy link
Member

hadley commented Jan 20, 2025

Can you please provide a reprex?

@luca850
Copy link
Author

luca850 commented Jan 21, 2025 via email

@hadley
Copy link
Member

hadley commented Jan 21, 2025

Hmmmm, this is fine when I run it in positron or in a reprex:

packageVersion("evaluate")
#> [1] '1.0.3'
dev.list()
#> quartz_off_screen 
#>                 2
evaluate::evaluate(
  " a <- 2",
  stop_on_error = 0,
  new_device = FALSE
)
#> <evaluation>
#> Source code: 
#>    a <- 2
dev.list()
#> quartz_off_screen 
#>                 2

Created on 2025-01-21 with reprex v2.1.0

But when I run it in a raw R terminal the first dev.list() returns NULL and evaluate does indeed open a new graphics device.

hadley added a commit that referenced this issue Jan 21, 2025
Because `par("page")` will open a device if one is not already open. Fixes #234.
@hadley hadley closed this as completed in 9b41223 Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants